Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Add more onnx operator export unit tests #20194

Merged
merged 3 commits into from
Apr 22, 2021
Merged

[v1.x] Add more onnx operator export unit tests #20194

merged 3 commits into from
Apr 22, 2021

Conversation

josephevans
Copy link
Contributor

Description

Fix onnx export for size_array by reshaping output from scalar to 1D tensor.

Adds onnx export unit tests for the following operators:

  • rnn_param_concat
  • size_array
  • sample_multinomial

@josephevans josephevans requested a review from szha as a code owner April 20, 2021 23:49
@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, windows-cpu, unix-cpu, centos-cpu, sanity, clang, miscellaneous, centos-gpu, windows-gpu, edge, unix-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Apr 20, 2021
Zha0q1
Zha0q1 approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 21, 2021
@Zha0q1 Zha0q1 merged commit 8c15875 into apache:v1.x Apr 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Zha0q1 Zha0q1 Zha0q1 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephevans @mxnet-bot @Zha0q1 @mseth10